Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast: fix the TiDB issue #8153 #27

Merged
merged 1 commit into from
Nov 10, 2018
Merged

ast: fix the TiDB issue #8153 #27

merged 1 commit into from
Nov 10, 2018

Conversation

dbjoa
Copy link
Contributor

@dbjoa dbjoa commented Nov 8, 2018

Required in the TiDB PR #8206

@shenli
Copy link
Member

shenli commented Nov 8, 2018

@dbjoa Thanks!
Please rebase the master and generate the parser.go again. We have fixed an issue that the generated parser.go is not stable. See: #9

@dbjoa
Copy link
Contributor Author

dbjoa commented Nov 8, 2018

@shenli Thank you for the guide. I've updated the PR.

@tiancaiamao
Copy link
Collaborator

PTAL @zz-jason @eurekaka

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli
Copy link
Member

shenli commented Nov 10, 2018

LGTM

@zz-jason
Copy link
Member

Hi @dbjoa, could you help us cherry pick this commit to the release-2.1 branch? I tried to cherry-pick but failed. Seems you need to sign the CLA?

@dbjoa
Copy link
Contributor Author

dbjoa commented Oct 10, 2019

@zz-jason
I've just signed the CLA.

tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants