goyacc: fix unstability of generated parser.go #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Some bits are taken from #8 which was closed by OP. 1. Renamed the rule `goyacc` to `bin/goyacc` so Makefile won't mistaken the directory not changed as the binary being built 2. Modified the generated message to include the words "DO NOT EDIT." recommended by [`go generate`], so IDEs can properly flag the file as generated. [`go generate`]: https://golang.org/pkg/cmd/go/internal/generate/
When two strings have the same lowercase value, break-even by comparing case-sensitively.
kennytm
force-pushed
the
kennytm/fix-goyacc-unstable
branch
from
4752949
to
50457f2
Compare
|
Good catch! |
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running
make parsertwo times may produce different contents inparser.go. This is because we have two pairs of tokens differed only by case: "Starting"/"starting" and "Constraint"/"constraint".goyaccby default sort the tokens by usage and lower-cased name usingsort.Sortwhich is unstable, causing non-deterministic output. This PR fixes the issue in the parser generator by forcing the upper-case tokens be sorted before the lower-case ones.This PR is needed for #6.