Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pb: update pb parser to avoid drainer failure #1093

Merged
merged 9 commits into from
Jan 13, 2022

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Nov 26, 2021

What problem does this PR solve?

close #1117.
When drainer syncing to pb meeting some unknown ddls, drainer will fail because of the unknown DDL.

What is changed and how it works?

Ignore this pb error when checking whether ddl is CreateDatabaseStmt

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8cba8b7

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e6d0e5d

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot
Copy link
Member

@lichunzhu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 194d4ac into pingcap:master Jan 13, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Jan 13, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1121.

ti-chi-bot pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Jan 13, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1122.

ti-chi-bot pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Jan 13, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1123.

ti-chi-bot pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Jan 13, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1124.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 5.3: error checking out 5.3: exit status 1. output: error: pathspec '5.3' did not match any file(s) known to git

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 5.4: error checking out 5.4: exit status 1. output: error: pathspec '5.4' did not match any file(s) known to git

@lichunzhu lichunzhu deleted the updatePBParseToAvoidBreakDown branch January 13, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drainer will exit when meeting unsupported ddl if dsyncer is pb
4 participants