Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pb: update pb parser to avoid drainer failure (#1093) #1122

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1093

What problem does this PR solve?

close #1117.
When drainer syncing to pb meeting some unknown ddls, drainer will fail because of the unknown DDL.

What is changed and how it works?

Ignore this pb error when checking whether ddl is CreateDatabaseStmt

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Release note

  • No release note

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 13, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lichunzhu
Copy link
Contributor

/run-all-tests

@lichunzhu lichunzhu force-pushed the cherry-pick-1093-to-release-5.1 branch from 40b51af to c91f6f6 Compare February 7, 2022 07:45
@lichunzhu
Copy link
Contributor

/run-all-tests

@niubell
Copy link

niubell commented Feb 8, 2022

/run-all-tests

@lichunzhu
Copy link
Contributor

/run-all-tests

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a668527

@lichunzhu
Copy link
Contributor

/run-unit-tests

@lichunzhu
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 32ff22e into pingcap:release-5.1 Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants