Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reparo/:Add worker-count, txn-batch config #742

Merged
merged 4 commits into from
Sep 5, 2019
Merged

reparo/:Add worker-count, txn-batch config #742

merged 4 commits into from
Sep 5, 2019

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

TOOL-1547
Add worker count and txn batch config for reparo. Users can decide these indecies themselves to change the sync speed of reparo.

What is changed and how it works?

Expose worker count and txn batch to config.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu lichunzhu changed the title /Reparo:Add worker-count, txn-batch config reparo/:Add worker-count, txn-batch config Sep 5, 2019
@WangXiangUSTC
Copy link
Contributor

need update cmd/reparo/reparo.toml, and add these two config's check in validate?
rest LGTM

july2993
july2993 reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update cmd/reparo/reparo.toml
rest LGTM

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

@WangXiangUSTC @july2993 Revised, PTAL.

july2993
july2993 reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WangXiangUSTC
WangXiangUSTC approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit 640c1ff into pingcap:master Sep 5, 2019
@lichunzhu lichunzhu deleted the czli/reparo/addWokerTxn branch September 5, 2019 06:32
@lichunzhu lichunzhu mentioned this pull request Sep 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@july2993 july2993 july2993 left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.1 status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lichunzhu @WangXiangUSTC @july2993