Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pump and drainer e2e bug #743

Closed
weekface opened this issue Aug 8, 2019 · 2 comments
Closed

pump and drainer e2e bug #743

weekface opened this issue Aug 8, 2019 · 2 comments
Assignees
@shuijing198799
Labels
type/bug Something isn't working

Comments

@weekface
Copy link
Contributor

weekface commented Aug 8, 2019

tidb-operator/tests/actions.go

Lines 2464 to 2466 in c348598

type pumpStatus struct {
StatusMap map[string]*nodeStatus
}

this struct needs json tag.

type pumpStatus struct {
	StatusMap map[string]*nodeStatus
}

should be:

type pumpStatus struct {
	StatusMap map[string]*nodeStatus `json:"status"`
}
@weekface weekface added the type/bug Something isn't working label Aug 8, 2019
@weekface
Copy link
Contributor Author

weekface commented Aug 8, 2019

@shuijing198799 PTAL

@weekface weekface mentioned this issue Aug 8, 2019
Merged
@shuijing198799
Copy link
Contributor

@shuijing198799 PTAL

This issue is fixed in #764 PTAL

yahonda pushed a commit that referenced this issue Dec 27, 2021
@DanielZhangQD
en, zh: add note for mysql 8.0 (#743)
0a9acc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shuijing198799 shuijing198799

Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weekface @shuijing198799