add affinity to pump/drainer #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
|
/run-e2e-tests |
weekface
force-pushed
the
pump-affinity
branch
5 times, most recently
from
aeeef85 to
160dcb0
Compare
weekface
force-pushed
the
pump-affinity
branch
3 times, most recently
from
2b243a0 to
81f21a2
Compare
weekface
requested review from
shuijing198799 and
xiaojingchen
and removed request for
shuijing198799
weekface
commented
Aug 8, 2019
| glog.Errorf("some pods is not health %s ,%v", pumpStatefulSetName, err) | ||
| return false, nil | ||
| glog.Errorf("some pods is not health %s", pumpStatefulSetName) | ||
| // return false, nil |
There was a problem hiding this comment.
there is a problem in method pumpHealth, will fix it in another pr: #743
| @@ -2377,7 +2389,12 @@ func (oa *operatorActions) CheckIncrementalBackup(info *TidbClusterConfig, withD | |||
| } | |||
| for _, pod := range pods.Items { | |||
| if !oa.drainerHealth(info, pod.Spec.Hostname) { | |||
| return false, nil | |||
| glog.Errorf("some pods is not health %s", drainerStatefulSetName) | |||
| // return false, nil | |||
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
cherry pick to release-1.0 in PR #746 |
tennix
pushed a commit
that referenced
this pull request
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
affinityto pump/drainerWhat is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: