stats: add metrics for dynamic update (#6278)

pingcap · Apr 13, 2018 · b51b0de · b51b0de
1 parent 533fac1
commit b51b0de
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/metrics/stats.go b/metrics/stats.go
@@ -52,11 +52,29 @@ var (
 			Name:      "pseudo_estimation_total",
 			Help:      "Counter of pseudo estimation caused by outdated stats.",
 		})
+
+	DumpFeedbackCounter = prometheus.NewCounterVec(
+		prometheus.CounterOpts{
+			Namespace: "tidb",
+			Subsystem: "statistics",
+			Name:      "dump_feedback_total",
+			Help:      "Counter of dumping feedback.",
+		}, []string{LblType})
+
+	UpdateStatsCounter = prometheus.NewCounterVec(
+		prometheus.CounterOpts{
+			Namespace: "tidb",
+			Subsystem: "statistics",
+			Name:      "update_stats_total",
+			Help:      "Counter of updating stats using feedback.",
+		}, []string{LblType})
 )
 
 func init() {
 	prometheus.MustRegister(AutoAnalyzeHistogram)
 	prometheus.MustRegister(AutoAnalyzeCounter)
 	prometheus.MustRegister(StatsInaccuracyRate)
 	prometheus.MustRegister(PseudoEstimation)
+	prometheus.MustRegister(DumpFeedbackCounter)
+	prometheus.MustRegister(UpdateStatsCounter)
 }
diff --git a/statistics/update.go b/statistics/update.go
@@ -221,6 +221,11 @@ func (h *Handle) dumpFeedbackToKV(fb *QueryFeedback) error {
 	sql := fmt.Sprintf("insert into mysql.stats_feedback (table_id, hist_id, is_index, feedback) values "+
 		"(%d, %d, %d, X'%X')", fb.tableID, fb.hist.ID, isIndex, vals)
 	_, err = h.ctx.(sqlexec.SQLExecutor).Execute(context.TODO(), sql)
+	if err != nil {
+		metrics.DumpFeedbackCounter.WithLabelValues(metrics.LblError).Inc()
+	} else {
+		metrics.DumpFeedbackCounter.WithLabelValues(metrics.LblOK).Inc()
+	}
 	return errors.Trace(err)
 }
 
@@ -288,9 +293,16 @@ func (h *Handle) HandleUpdateStats(is infoschema.InfoSchema) error {
 	return errors.Trace(err)
 }
 
-func (h *Handle) dumpStatsUpdateToKV(tableID int64, isIndex int, q *QueryFeedback, hist *Histogram, cms *CMSketch) error {
+func (h *Handle) dumpStatsUpdateToKV(tableID int64, isIndex int, q *QueryFeedback, hist *Histogram, cms *CMSketch) (err error) {
+	defer func() {
+		if err != nil {
+			metrics.UpdateStatsCounter.WithLabelValues(metrics.LblError).Inc()
+		} else {
+			metrics.UpdateStatsCounter.WithLabelValues(metrics.LblOK).Inc()
+		}
+	}()
 	hist = UpdateHistogram(hist, q)
-	err := SaveStatsToStorage(h.ctx, tableID, -1, isIndex, hist, cms)
+	err = SaveStatsToStorage(h.ctx, tableID, -1, isIndex, hist, cms)
 	if err != nil {
 		return errors.Trace(err)
 	}