Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: add metrics for dynamic update #6278

Merged
merged 3 commits into from
Apr 13, 2018
Merged

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Apr 12, 2018

This PR adds metrics for dumping stats feedback and updating stats using feedback.
PTAL @coocood @winoros @shenli

@zz-jason
Copy link
Member

LGTM

@zz-jason
Copy link
Member

don't forget to update grafana config in tidb-ansible

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 12, 2018

/run-all-tests

@zhexuany zhexuany merged commit b51b0de into pingcap:master Apr 13, 2018
@alivxxx alivxxx deleted the metrics branch April 13, 2018 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants