chore: make bazel running without nogo (#54170)

close #50400
pingcap · Jun 25, 2024 · bb96e33 · bb96e33
1 parent 99abc28
commit bb96e33
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -626,9 +626,9 @@ bazel_coverage_test: failpoint-enable bazel_ci_simple_prepare
 bazel_build:
 	mkdir -p bin
 	bazel $(BAZEL_GLOBAL_CONFIG) build $(BAZEL_CMD_CONFIG) \
-		//... --//build:with_nogo_flag=true
+		//... --//build:with_nogo_flag=$(NOGO_FLAG)
 	bazel $(BAZEL_GLOBAL_CONFIG) build $(BAZEL_CMD_CONFIG) \
-		//cmd/importer:importer //cmd/tidb-server:tidb-server //cmd/tidb-server:tidb-server-check --//build:with_nogo_flag=true
+		//cmd/importer:importer //cmd/tidb-server:tidb-server //cmd/tidb-server:tidb-server-check --//build:with_nogo_flag=$(NOGO_FLAG)
 	cp bazel-out/k8-fastbuild/bin/cmd/tidb-server/tidb-server_/tidb-server ./bin
 	cp bazel-out/k8-fastbuild/bin/cmd/importer/importer_/importer      ./bin
 	cp bazel-out/k8-fastbuild/bin/cmd/tidb-server/tidb-server-check_/tidb-server-check ./bin
@@ -778,7 +778,7 @@ bazel_flashbacktest: failpoint-enable bazel_ci_simple_prepare
 
 .PHONY: bazel_lint
 bazel_lint: bazel_prepare
-	bazel build //... --//build:with_nogo_flag=true
+	bazel build //... --//build:with_nogo_flag=$(NOGO_FLAG)
 
 .PHONY: docker
 docker:

diff --git a/Makefile.common b/Makefile.common
@@ -131,3 +131,5 @@ ifneq ("$(CI)", "")
 	BAZEL_SYNC_CONFIG := --repository_cache=/home/jenkins/.tidb/tmp
 endif
 BAZEL_INSTRUMENTATION_FILTER := --instrument_test_targets --instrumentation_filter=//pkg/...,//br/...,//dumpling/...
+
+NOGO_FLAG=true