Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make bazel running without nogo #54170

Merged

Conversation

ei-sugimoto
Copy link
Contributor

@ei-sugimoto ei-sugimoto commented Jun 23, 2024

What problem does this PR solve?

Issue Number: close #50400

Problem Summary:

What changed and how does it work?

The developer can choose whether or not to run nogo when doing make bazel.
The initial value of nogo_FLAG is true.

$ time make NOGO_FLAG=true
CGO_ENABLED=1  GO111MODULE=on go build -tags codes  -ldflags '-X "github.com/pingcap/tidb/pkg/parser/mysql.TiDBReleaseVersion=v8.2.0-alpha-406-g255c08f58c" -X "github.com/pingcap/tidb/pkg/util/versioninfo.TiDBBuildTS=2024-06-23 12:34:35" -X "github.com/pingcap/tidb/pkg/util/versioninfo.TiDBGitHash=255c08f58cd611da3c204a2054fd2dab5e9c34f1" -X "github.com/pingcap/tidb/pkg/util/versioninfo.TiDBGitBranch=feat/make-bazel-running-without-nogo" -X "github.com/pingcap/tidb/pkg/util/versioninfo.TiDBEdition=Community" ' -o bin/tidb-server ./cmd/tidb-server
Build TiDB Server successfully!

real    0m16.067s
user    0m19.027s
sys     0m2.475s
$ time make NOGO_FLAG=false
CGO_ENABLED=1  GO111MODULE=on go build -tags codes  -ldflags '-X "github.com/pingcap/tidb/pkg/parser/mysql.TiDBReleaseVersion=v8.2.0-alpha-406-g255c08f58c" -X "github.com/pingcap/tidb/pkg/util/versioninfo.TiDBBuildTS=2024-06-23 12:35:28" -X "github.com/pingcap/tidb/pkg/util/versioninfo.TiDBGitHash=255c08f58cd611da3c204a2054fd2dab5e9c34f1" -X "github.com/pingcap/tidb/pkg/util/versioninfo.TiDBGitBranch=feat/make-bazel-running-without-nogo" -X "github.com/pingcap/tidb/pkg/util/versioninfo.TiDBEdition=Community" ' -o bin/tidb-server ./cmd/tidb-server
Build TiDB Server successfully!

real    0m13.757s
user    0m16.300s
sys     0m1.957s

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 23, 2024
Copy link

ti-chi-bot bot commented Jun 23, 2024

Hi @ei-sugimoto. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jun 23, 2024

Hi @ei-sugimoto. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 23, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed do-not-merge/needs-tests-checked labels Jun 23, 2024
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.5356%. Comparing base (74accb3) to head (61cf217).
Report is 20 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54170         +/-   ##
=================================================
- Coverage   72.9483%   55.5356%   -17.4128%     
=================================================
  Files          1520       1643        +123     
  Lines        434902     611647     +176745     
=================================================
+ Hits         317254     339682      +22428     
- Misses        98179     248641     +150462     
- Partials      19469      23324       +3855     
Flag Coverage Δ
integration 22.4987% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.4999% <ø> (+6.3307%) ⬆️

Makefile Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 25, 2024
Copy link

ti-chi-bot bot commented Jun 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-23 15:03:46.485040943 +0000 UTC m=+559152.970529774: ☑️ agreed by hawkingrei.
  • 2024-06-25 06:52:57.494603347 +0000 UTC m=+702503.980092180: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit bb96e33 into pingcap:master Jun 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make bazel running without nogo
3 participants