Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make bazel running without nogo #54170

Merged
merged 6 commits into from
Jun 25, 2024
Merged

chore: make bazel running without nogo #54170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2c1af5e
add test for send task
ei-sugimoto Jun 19, 2024
80d64a5
Merge branch 'master' into add-negative-testing-for-plan-replayer
ei-sugimoto Jun 22, 2024
f0a83fb
fix : ci : Applying the presented git diff
ei-sugimoto Jun 22, 2024
255c08f
feat: add `NOGO_FLAG` argment
ei-sugimoto Jun 23, 2024
ec9422b
Merge branch 'master' into feat/make-bazel-running-without-nogo
ei-sugimoto Jun 23, 2024
61cf217
feat: move `NOGO_FLAG` to `Makefile.common`
ei-sugimoto Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,9 +627,9 @@ bazel_coverage_test: failpoint-enable bazel_ci_simple_prepare
bazel_build:
mkdir -p bin
bazel $(BAZEL_GLOBAL_CONFIG) build $(BAZEL_CMD_CONFIG) \
//... --//build:with_nogo_flag=true
//... --//build:with_nogo_flag=$(NOGO_FLAG)
bazel $(BAZEL_GLOBAL_CONFIG) build $(BAZEL_CMD_CONFIG) \
//cmd/importer:importer //cmd/tidb-server:tidb-server //cmd/tidb-server:tidb-server-check --//build:with_nogo_flag=true
//cmd/importer:importer //cmd/tidb-server:tidb-server //cmd/tidb-server:tidb-server-check --//build:with_nogo_flag=$(NOGO_FLAG)
cp bazel-out/k8-fastbuild/bin/cmd/tidb-server/tidb-server_/tidb-server ./bin
cp bazel-out/k8-fastbuild/bin/cmd/importer/importer_/importer ./bin
cp bazel-out/k8-fastbuild/bin/cmd/tidb-server/tidb-server-check_/tidb-server-check ./bin
Expand Down Expand Up @@ -779,7 +779,7 @@ bazel_flashbacktest: failpoint-enable bazel_ci_simple_prepare

.PHONY: bazel_lint
bazel_lint: bazel_prepare
bazel build //... --//build:with_nogo_flag=true
bazel build //... --//build:with_nogo_flag=$(NOGO_FLAG)

.PHONY: docker
docker:
Expand Down
2 changes: 2 additions & 0 deletions Makefile.common
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,5 @@ ifneq ("$(CI)", "")
BAZEL_SYNC_CONFIG := --repository_cache=/home/jenkins/.tidb/tmp
endif
BAZEL_INSTRUMENTATION_FILTER := --instrument_test_targets --instrumentation_filter=//pkg/...,//br/...,//dumpling/...

NOGO_FLAG=true