Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make coprocessor paging as the default RPC protocol #35633

Closed
24 tasks done
tiancaiamao opened this issue Jun 22, 2022 · 1 comment
Closed
24 tasks done

Make coprocessor paging as the default RPC protocol #35633

tiancaiamao opened this issue Jun 22, 2022 · 1 comment
Assignees
Labels
type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@tiancaiamao
Copy link
Contributor

tiancaiamao commented Jun 22, 2022

Feature Request

The background is that when we turn to use chunk encoding in the RPC, the grpc packet size become quite big.
A 96M region may amplify to 900M-1G when using chunk encoding.
And this account for some OOM issues.

So to alleviate the OOM cases, we have to avoid the grpc packet being too big.

One way is to use the coprocessor streaming, and the other way is coprocessor paging.
The streaming has some known issues and is lack of maintance, so it's deprecated #20759.

We have an internal doc about the details. The conclusion is that we'll turn to coprocessor paging and make it the default protocol.

Describe the feature you'd like:

This issue tracks the process of the development/testing.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Done

TODO

IN REVIEW

WIP

@tiancaiamao
Copy link
Contributor Author

The internal test report here

br restore a dataset:
image

tpch50 table scan:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant