-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session,sessionctx: enable tidb_enable_paging by default #35275
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2e4ebf4d5586ece5245b6942669db5ea8e78781a |
/run-check_dev_2 |
ref #35633 |
@tiancaiamao: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2e4ebf4
|
/run-realtikv-test |
/run-mysql-test |
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #35273
Problem Summary:
Please review #35244 first, this is based on that PR.What is changed and how it works?
Set the default
tidb_enable_paging
value to true.For the newly bootstraped cluster, the global variable
tidb_enable_paging
is set.For the old cluster, the default value is not changed.
The would make us cover the bugs as soon as possible before the next release.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.