Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: support batch ddl for sql restore #48301

Closed
BornChanger opened this issue Nov 5, 2023 · 6 comments · Fixed by #49089
Closed

br: support batch ddl for sql restore #48301

BornChanger opened this issue Nov 5, 2023 · 6 comments · Fixed by #49089
Assignees
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/enhancement The issue or PR belongs to an enhancement.

Comments

@BornChanger
Copy link
Contributor

BornChanger commented Nov 5, 2023

Enhancement

Restore sql execution does not support batch ddl as in restore clp. It's a performance issue, and we need to provide the support to SQL restore.

@BornChanger BornChanger added the type/enhancement The issue or PR belongs to an enhancement. label Nov 5, 2023
@BornChanger
Copy link
Contributor Author

/component br

@ti-chi-bot ti-chi-bot bot added the component/br This issue is related to BR of TiDB. label Nov 5, 2023
@BornChanger
Copy link
Contributor Author

/severity major

@BornChanger
Copy link
Contributor Author

/assign @Leavrth

@Leavrth
Copy link
Contributor

Leavrth commented Nov 30, 2023

If directly use the sessionCtx of the brie executer, the processlist would be other SQL:

MySQL [(none)]> show processlist;
+----------+------+-----------------+------+---------+------+------------+------------------------------------------------------------------------------------------------------+
| Id       | User | Host            | db   | Command | Time | State      | Info                                                                                                 |
+----------+------+-----------------+------+---------+------+------------+------------------------------------------------------------------------------------------------------+
| 85983238 | root | 127.0.0.1:47606 | NULL | Query   |    1 | autocommit | update `mysql`.`stats_meta` set snapshot = 445989087621414917, version = 445989087621414917, count = |
| 85983240 | root | 127.0.0.1:47722 | NULL | Query   |    0 | autocommit | show processlist                                                                                     |
+----------+------+-----------------+------+---------+------+------------+------------------------------------------------------------------------------------------------------+
2 rows in set (0.00 sec)

@BornChanger
Copy link
Contributor Author

/label needs-cherry-pick-6.5

Copy link

ti-chi-bot bot commented Dec 27, 2023

@BornChanger: The label(s) needs-cherry-pick-6.5 cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, good first issue, correctness, duplicate, proposal, security, ok-to-test, needs-ok-to-test, needs-more-info, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5.

In response to this:

/label needs-cherry-pick-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Leavrth Leavrth added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Dec 27, 2023
ti-chi-bot bot pushed a commit that referenced this issue Dec 27, 2023
ti-chi-bot bot pushed a commit that referenced this issue Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants