Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brie: support batch ddl for sql restore #49089

Merged
merged 13 commits into from
Dec 27, 2023
Merged

brie: support batch ddl for sql restore #49089

merged 13 commits into from
Dec 27, 2023

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Dec 1, 2023

What problem does this PR solve?

Issue Number: close #48301

Problem Summary:
brie restore need batch ddl to accelerate the table creation。

What changed and how does it work?

implement CreateTables function for brieGlue

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Leavrth
draft
62d1b9b 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
support create tables for brie glue
5564b07 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 1, 2023
@tiprow tiprow
Copy link

tiprow bot commented Dec 1, 2023

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Merging #49089 (f2e6bee) into master (6c6c127) will increase coverage by 1.8245%.
Report is 6 commits behind head on master.
The diff coverage is 9.9447%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #49089        +/-   ##
================================================
+ Coverage   70.9219%   72.7465%   +1.8245%     
================================================
  Files          1368       1432        +64     
  Lines        396364     416743     +20379     
================================================
+ Hits         281109     303166     +22057     
+ Misses        95564      93896      -1668     
+ Partials      19691      19681        -10
Flag Coverage Δ
integration 47.0110% <9.9447%> (?)
unit 70.9347% <ø> (+0.0128%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 57.6023% <78.2608%> (+4.6990%) ⬆️

@Leavrth
make bazel happy
518c9ef 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
make bazel happy
910767a 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
make bazel happy
933e2a0 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
make bazel happy
20ccd36 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Leavrth
Leavrth commented Dec 8, 2023
View reviewed changes
pkg/executor/brie.go Outdated
@@ -101,7 +100,7 @@ func (p *brieTaskProgress) Close() {
p.lock.Lock()
current := atomic.LoadInt64(&p.current)
if current < p.total {
p.cmd = fmt.Sprintf("%s Cacneled", p.cmd)
p.cmd = fmt.Sprintf("%s Cancelled", p.cmd)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cancelled or Canceled?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall right TiKV prefers AmE (canceled). For me I think both will be OK.

@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 8, 2023

/test pull-br-integration-test

@tiprow tiprow
Copy link

tiprow bot commented Dec 8, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 27, 2023

/test pull-br-integration-test

@tiprow tiprow
Copy link

tiprow bot commented Dec 27, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
fix realtikvtest
07fd90e 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 27, 2023

/test pull-br-integration-test

@tiprow tiprow
Copy link

tiprow bot commented Dec 27, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

YuJuncen
YuJuncen approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/executor/brie.go Outdated
@@ -101,7 +100,7 @@ func (p *brieTaskProgress) Close() {
p.lock.Lock()
current := atomic.LoadInt64(&p.current)
if current < p.total {
p.cmd = fmt.Sprintf("%s Cacneled", p.cmd)
p.cmd = fmt.Sprintf("%s Cancelled", p.cmd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall right TiKV prefers AmE (canceled). For me I think both will be OK.

tests/realtikvtest/brietest/backup_restore_test.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 27, 2023
@Leavrth
commit some suggestions
891972d 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
add more tables
c9d9161 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 27, 2023

/test pull-br-integration-test

@tiprow tiprow
Copy link

tiprow bot commented Dec 27, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 27, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-27 03:53:42.841943357 +0000 UTC m=+1624313.879170268: ☑️ agreed by YuJuncen.
  • 2023-12-27 07:10:45.697455312 +0000 UTC m=+1636136.734682241: ☑️ agreed by 3pointer.

@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 27, 2023

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2023
@Leavrth
fix integration test
f2e6bee 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 27, 2023

/test pull-br-integration-test

@tiprow tiprow
Copy link

tiprow bot commented Dec 27, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 27, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2023
@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 27, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 27, 2023
@BornChanger
Copy link
Contributor

/retest

@Leavrth Leavrth changed the title brie: suuport batch ddl for sql restore brie: support batch ddl for sql restore Dec 27, 2023
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Dec 27, 2023
@tiprow tiprow
Copy link

tiprow bot commented Dec 27, 2023

@Leavrth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test f2e6bee link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 8709bb5 into pingcap:master Dec 27, 2023
26 of 27 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #49849.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 27, 2023
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 27, 2023
@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#49089
f10bf0e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #49850.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 27, 2023
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 27, 2023
@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#49089
21f935c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #49851.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 27, 2023
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 27, 2023
@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#49089
aec33e8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 28, 2023
@ti-chi-bot
brie: support batch ddl for sql restore (#49089) (#49851)
767ec62 
close #48301
ti-chi-bot bot pushed a commit that referenced this pull request Feb 4, 2024
@ti-chi-bot
brie: support batch ddl for sql restore (#49089) (#49850)
c4ab1ae 
close #48301
ti-chi-bot bot pushed a commit that referenced this pull request Feb 28, 2024
@ti-chi-bot
brie: support batch ddl for sql restore (#49089) (#49849)
8aa07d2 
close #48301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: support batch ddl for sql restore
5 participants
@Leavrth @BornChanger @ti-chi-bot @3pointer @YuJuncen