-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: keep unfoldable exprs when pruning columns for ORDER BY items #10064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rand
skip pruningRAND()
when pruning columns for ORDER BY items
/run-all-tests |
it seems there are another order by pruning bug when subquery order by correlate column - - but solved by this PR |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-integration-ddl-test |
This change is because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RAND()
when pruning columns for ORDER BY items
What problem does this PR solve?
fixes #9033
What is changed and how it works?
pruning column logic will do prune if order by expression with zero columns(it's right for sql like
order by abs(1)
), butrand()
shouldn't be pruned, so do skip logic.Check List
Tests
Code changes
Side effects
Related changes
This change is