Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: avoid Order By constant expression error when plan cache is enabled (#16261) #16674

Merged
merged 7 commits into from
Apr 28, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 21, 2020

cherry-pick #16261 to release-3.1


What problem does this PR solve?

Issue Number: close #16203

Problem Summary:

Error is reported for order by rand() when plan cache is enabled.

What is changed and how it works?

What's Changed:

  • remove Rand / Sysdate / UUID from DeferredFunctions, because they should not be folded into constant according to unFoldableFunctions, otherwise, they would be converted to a Constant with DeferredExpr in funcCallToExpression. This change makes the behavior regarding these functions consistent when plan cache is enabled / disabled.

  • check if the order by items can be treated as constants during execution using a new function, instead of IsMutableEffectsExpr, which is specifically designed for de-duplicating expressions.

How it Works:

Related previous PRs for this change:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 21, 2020

/run-all-tests

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@eurekaka eurekaka force-pushed the release-3.1-692e0098b120 branch from e7d98f9 to c12ad04 Compare April 23, 2020 03:44
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2020
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 27, 2020
@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2020
@zz-jason zz-jason removed the request for review from wshwsh12 April 27, 2020 07:07
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 27, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 27, 2020

/run-all-tests

@eurekaka
Copy link
Contributor

/run-check_dev

@eurekaka eurekaka merged commit b38f8a2 into pingcap:release-3.1 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants