-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: avoid Order By
constant expression error when plan cache is enabled (#16261)
#16674
Merged
eurekaka
merged 7 commits into
pingcap:release-3.1
from
sre-bot:release-3.1-692e0098b120
Apr 28, 2020
Merged
expression: avoid Order By
constant expression error when plan cache is enabled (#16261)
#16674
eurekaka
merged 7 commits into
pingcap:release-3.1
from
sre-bot:release-3.1-692e0098b120
Apr 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
sre-bot
added
component/expression
sig/planner
SIG: Planner
type/3.1-cherry-pick
type/bugfix
This PR fixes a bug.
labels
Apr 21, 2020
eurekaka
force-pushed
the
release-3.1-692e0098b120
branch
from
April 23, 2020 03:34
8de93d3
to
73b0859
Compare
Signed-off-by: sre-bot <sre-bot@pingcap.com>
eurekaka
force-pushed
the
release-3.1-692e0098b120
branch
from
April 23, 2020 03:44
e7d98f9
to
c12ad04
Compare
zz-jason
reviewed
Apr 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lzmhhh123
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lzmhhh123
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Apr 27, 2020
zz-jason
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Apr 27, 2020
/run-all-tests |
/run-all-tests |
/run-check_dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/expression
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
type/3.1-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16261 to release-3.1
What problem does this PR solve?
Issue Number: close #16203
Problem Summary:
Error is reported for
order by rand()
when plan cache is enabled.What is changed and how it works?
What's Changed:
remove
Rand
/Sysdate
/UUID
fromDeferredFunctions
, because they should not be folded into constant according tounFoldableFunctions
, otherwise, they would be converted to aConstant
withDeferredExpr
infuncCallToExpression
. This change makes the behavior regarding these functions consistent when plan cache is enabled / disabled.check if the order by items can be treated as constants during execution using a new function, instead of
IsMutableEffectsExpr
, which is specifically designed for de-duplicating expressions.How it Works:
Related previous PRs for this change:
now()
;order by rand()
when plan cache is disabled by usingConstItem()
;order by
clause #11839: second fix fororder by rand()
when plan cache is disabled by usingIsMutableEffectsExpr()
;Related changes
Check List
Tests
Side effects
N/A
Release note