types: convert EOF error to ErrTruncate when parse duration #11865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11865 +/- ##
===========================================
Coverage 82.0162% 82.0162%
===========================================
Files 438 438
Lines 100585 100585
===========================================
Hits 82496 82496
Misses 12491 12491
Partials 5598 5598 |
iosmanthus
previously approved these changes
Aug 26, 2019
wjhuang2016
added
component/expression
needs-cherry-pick-2.1
status/LGT1
zz-jason
reviewed
Aug 26, 2019
|
|
||
| // fix issue 10308 | ||
| result = tk.MustQuery("select time(\"- -\");") | ||
| result.Check(testkit.Rows("00:00:00")) |
There was a problem hiding this comment.
would mysql through a warning?
There was a problem hiding this comment.
would mysql through a warning?
Both MySQL and TiDB through a warning:
mysql> show warnings;
+---------+------+---------------------------------------+
| Level | Code | Message |
+---------+------+---------------------------------------+
| Warning | 1292 | Truncated incorrect time value: '- -' |
+---------+------+---------------------------------------+
1 row in set (0.00 sec)
There was a problem hiding this comment.
Got it. Could you also test the warning message?
There was a problem hiding this comment.
Got it. Could you also test the warning message?
Done
|
|
iosmanthus
approved these changes
Aug 26, 2019
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 in PR #11893 |
ngaut
pushed a commit
that referenced
this pull request
Aug 28, 2019
zz-jason
pushed a commit
that referenced
this pull request
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #10308
What is changed and how it works?
convert EOF error to ErrTruncate
Check List
Tests
Code changes
Side effects
Related changes