server: call cc.writeError when get io.EOF err
#13104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
|
/tests |
Codecov Report
@@ Coverage Diff @@
## master #13104 +/- ##
===============================================
- Coverage 80.174% 80.0673% -0.1068%
===============================================
Files 468 468
Lines 110557 110246 -311
===============================================
- Hits 88638 88271 -367
- Misses 15136 15195 +59
+ Partials 6783 6780 -3 |
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
…b into call_writeErr_when_get_EOF_err
|
close |
|
In case mysql.ComQuit:
return io.EOFso it is better to close this PR to avoid doing harm to the compatibility with mysql protocol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: H-ZeX hzx20112012@gmail.com
What problem does this PR solve?
This issue's(#10308) bug had be fix in #11865. However, we can not cover all function that return
io.EOFerr and convert it to another err, then problem such like #10308 may very likely reappear in some other sql.What is changed and how it works?
call
err = cc.writeError(err)even when getio.EOF.Check List
existing test.
Code changes
No.
Side effects
No.
Related changes
Release note