config: disable local latch by default #12068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
jackysp
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #12068 +/- ##
===========================================
Coverage 81.4778% 81.4778%
===========================================
Files 448 448
Lines 95939 95939
===========================================
Hits 78169 78169
Misses 12200 12200
Partials 5570 5570 |
|
LTGM @winkyao |
|
LGTM |
tiancaiamao
added
status/LGT2
tiancaiamao
approved these changes
Sep 9, 2019
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #12095 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
The local latch has a large memory usage for TiDB when importing data. In addition, there is a problem of inconsistency in the error message of the write conflict. After TiDB 3.0 supported pessimistic transaction, its role in reducing conflicts was also weakened. So, it is best to turn it off by default.
What is changed and how it works?
Turn it off by default.
Check List
Tests
Code changes
Related changes
tidb-ansiblerepository