Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: disable local latch by default (#12068) #12095

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 9, 2019

cherry-pick #12068 to release-3.0


Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

The local latch has a large memory usage for TiDB when importing data. In addition, there is a problem of inconsistency in the error message of the write conflict. After TiDB 3.0 supported pessimistic transaction, its role in reducing conflicts was also weakened. So, it is best to turn it off by default.

What is changed and how it works?

Turn it off by default.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the tidb-ansible repository

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 9, 2019

/run-all-tests

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit 7f41ed3 into pingcap:release-3.0 Sep 9, 2019
francis0407 added a commit to francis0407/tidb that referenced this pull request Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants