-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix inconsistent of grants privileges with MySQL when executing grant all on ...
#12330
Conversation
grant all on ...
@tsthght Please fix test below:
And add some test to test |
Codecov Report
@@ Coverage Diff @@
## master #12330 +/- ##
===========================================
Coverage 80.0356% 80.0356%
===========================================
Files 465 465
Lines 107136 107136
===========================================
Hits 85747 85747
Misses 14951 14951
Partials 6438 6438 |
/rebuild |
/run-unit-test |
Any update? @tsthght |
It will be updated today. |
You can use |
Great! Thank you, I will try it~ |
/run-all-tests |
/run-all-tests |
/run-integration-common-test tidb-test=pr/926 |
/run-all-tests tidb-test=pr/926 |
/run-all-tests |
/run-all-tests tidb-test=pr/926 |
I will approve after test merge, wait a moment. |
LGTM |
/run-all-tests tidb-test=pr/926 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ect/tidb into feature-add-udf-support * 'feature-add-udf-support' of https://github.com/JustProject/tidb: (26 commits) *: fix bug that the kill command doesn't work when the killed session is waiting for the pessimistic lock (pingcap#12852) executor: fix the projection upon the indexLookUp in indexLookUpJoin can't get result. (pingcap#12889) planner, executor: support create view on union (pingcap#12595) planner/cascades: introduce TransformationID in cascades planner (pingcap#12879) executor: fix data race in test (pingcap#12910) executor: reuse chunk row for insert on duplicate update (pingcap#12847) ddl: speed up tests (pingcap#12888) executor: speed up test (pingcap#12896) expression: implement vectorized evaluation for `builtinSecondSig` (pingcap#12886) expression: implement vectorized evaluation for `builtinJSONObjectSig` (pingcap#12663) expression: speed up builtinRepeatSig by using MergeNulls (pingcap#12674) expression: speed up unit tests under the expression package (pingcap#12887) store,kv: snapshot doesn't cache the non-exists kv entries lead to poor 'insert ignore' performance (pingcap#12872) executor: fix data race in `GetDirtyTable()` (pingcap#12767) domain: increase TTL to reduce the occurrence of reporting min startTS errors (pingcap#12578) executor: split test for speed up (pingcap#12881) executor: fix inconsistent of grants privileges with MySQL when executing `grant all on ...` (pingcap#12330) expression: implement vectorized evaluation for `builtinJSONUnquoteSig` (pingcap#12841) tune grpc connection count between tidb and tikv (pingcap#12884) Makefile: change test parallel to 8 (pingcap#12885) ...
…ting `grant all on ...` (pingcap#12330)
…ting `grant all on ...` (pingcap#12330)
What problem does this PR solve?
1 fix bug for #12324
2 fix bug for execute SQL
show grants for xxx
What is changed and how it works?
create user "ght1";
grant all on . to 'ght1'@'%' identified by 'Poiuy123';
select * from mysql.user where user='ght1'\G
*************************** 1. row ***************************
Grant_priv: N
Check List
Tests