planner, executor: support create view on union #12595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
force-pushed
the
view_on_union
branch
from
d3b4cea
to
5f53036
Compare
Codecov Report
@@ Coverage Diff @@
## master #12595 +/- ##
===========================================
Coverage 80.0849% 80.0849%
===========================================
Files 465 465
Lines 107597 107597
===========================================
Hits 86169 86169
Misses 14976 14976
Partials 6452 6452 |
XuHuaiyu
changed the title
XuHuaiyu
added
sig/execution
XuHuaiyu
force-pushed
the
view_on_union
branch
from
63081b2
to
1978a92
Compare
XuHuaiyu
force-pushed
the
view_on_union
branch
from
1978a92
to
69e4072
Compare
wshwsh12
reviewed
Oct 11, 2019
executor/ddl_test.go
Outdated
| _, err = tk.Exec("select * from v") | ||
| c.Assert(terror.ErrorEqual(err, plannercore.ErrViewInvalid), IsTrue) | ||
| tk.MustExec("alter table t1 add column a int") | ||
| tk.MustQuery("select * from v").Sort().Check(testkit.Rows("1 1", "3 1", "<nil> 1", "<nil> 2")) |
There was a problem hiding this comment.
I think the test case is wrong.
It should be tk.MustQuery("select * from v").Sort().Check(testkit.Rows("1 1", "1 3", "<nil> 1", "<nil> 2"))
The result is different from MySQL.
mysql> select * from v;
+------+------+
| a | b |
+------+------+
| NULL | 2 |
| NULL | 1 |
| 1 | 1 |
| 1 | 3 |
+------+------+
4 rows in set (0.00 sec)
tidb> select * from v;
+---+---+
| a | b |
+---+---+
| NULL | 2 |
| 3 | 1 |
| NULL | 1 |
| 1 | 1 |
+---+---+
4 rows in set (0.00 sec)
|
/run-all-tests |
SunRunAway
reviewed
Oct 23, 2019
|
@SunRunAway CI failed before I run |
wshwsh12
added
status/LGT2
|
/run-all-tests |
|
@XuHuaiyu merge failed. |
|
/run-all-tests |
|
/rebuild |
|
/run-all-tests |
lfkdsk
added a commit
to JustProject/tidb
that referenced
this pull request
Oct 26, 2019
…ect/tidb into feature-add-udf-support * 'feature-add-udf-support' of https://github.com/JustProject/tidb: (26 commits) *: fix bug that the kill command doesn't work when the killed session is waiting for the pessimistic lock (pingcap#12852) executor: fix the projection upon the indexLookUp in indexLookUpJoin can't get result. (pingcap#12889) planner, executor: support create view on union (pingcap#12595) planner/cascades: introduce TransformationID in cascades planner (pingcap#12879) executor: fix data race in test (pingcap#12910) executor: reuse chunk row for insert on duplicate update (pingcap#12847) ddl: speed up tests (pingcap#12888) executor: speed up test (pingcap#12896) expression: implement vectorized evaluation for `builtinSecondSig` (pingcap#12886) expression: implement vectorized evaluation for `builtinJSONObjectSig` (pingcap#12663) expression: speed up builtinRepeatSig by using MergeNulls (pingcap#12674) expression: speed up unit tests under the expression package (pingcap#12887) store,kv: snapshot doesn't cache the non-exists kv entries lead to poor 'insert ignore' performance (pingcap#12872) executor: fix data race in `GetDirtyTable()` (pingcap#12767) domain: increase TTL to reduce the occurrence of reporting min startTS errors (pingcap#12578) executor: split test for speed up (pingcap#12881) executor: fix inconsistent of grants privileges with MySQL when executing `grant all on ...` (pingcap#12330) expression: implement vectorized evaluation for `builtinJSONUnquoteSig` (pingcap#12841) tune grpc connection count between tidb and tikv (pingcap#12884) Makefile: change test parallel to 8 (pingcap#12885) ...
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Oct 28, 2019
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Oct 28, 2019
This was referenced Oct 28, 2019
zz-jason
pushed a commit
that referenced
this pull request
Oct 28, 2019
zz-jason
pushed a commit
that referenced
this pull request
Oct 28, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related PR:
pingcap/parser#572
What problem does this PR solve?
What is changed and how it works?
ErrViewInvalidwhen buildViewFromDatasource raises an error during building the logical planCheck List
Tests
Code changes
Side effects
N/A
Related changes
Release note
[bug-fix] Support create view on a union statement. Creating view on a union statement will cause a syntax error before.