-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: log each com_stmt_fetch
separately (#11987)
#12392
Merged
sre-bot
merged 3 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-74eaf327e953
Sep 25, 2019
Merged
*: log each com_stmt_fetch
separately (#11987)
#12392
sre-bot
merged 3 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-74eaf327e953
Sep 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
sre-bot
requested review from
cfzjywxk,
coocood,
jackysp,
tiancaiamao and
zz-jason
September 25, 2019 10:01
/run-unit-test |
jackysp
reviewed
Sep 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
coocood
approved these changes
Sep 25, 2019
coocood
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Sep 25, 2019
/run-all-tests |
/run-cherry-picker |
1 similar comment
/run-cherry-picker |
cherry pick to release-3.1 failed |
/run-cherry-picker |
/run-cherry-picker |
/run-cherry-picker |
3 similar comments
/run-cherry-picker |
/run-cherry-picker |
/run-cherry-picker |
cherry pick to release-3.1 in PR #13302 |
zz-jason
pushed a commit
that referenced
this pull request
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/server
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT1
Indicates that a PR has LGTM 1.
type/usability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #11987 to release-3.0
What problem does this PR solve?
to slow log:
In the current master code, slow log will be wrong value(
last fetch time(or new start execute time) - last cmd time
)In 2.1 code, slow log will be incompatible value(
last fetch time(or new start execute time) - first com_stmt_execute
time)but mysql record com_stmt_exec and com_stmt_fetch for each request.
this pr will change the behavior as MySQL does, although TiDB and MySQL use very different way to handle cursor:
so, you may see mysql stmt_execute is slow but fetch super fast, and TiDB both execute and fetch is slow in log.
What is changed and how it works?
InPreapre
andHasMoreResult
in slow log too(help find question)Parse_time
andCompile_time
in slow log(it seems miss those two fields)Check List
Tests
Code changes
Side effects
Related changes
tidb-ansible
repositoryRelease note
This change is