*: log each com_stmt_fetch
separately (#11987) (#12392)
#13302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #12392 to release-3.1
cherry-pick #11987 to release-3.0
What problem does this PR solve?
to slow log:
In the current master code, slow log will be wrong value(
last fetch time(or new start execute time) - last cmd time
)In 2.1 code, slow log will be incompatible value(
last fetch time(or new start execute time) - first com_stmt_execute
time)but mysql record com_stmt_exec and com_stmt_fetch for each request.
this pr will change the behavior as MySQL does, although TiDB and MySQL use very different way to handle cursor:
so, you may see mysql stmt_execute is slow but fetch super fast, and TiDB both execute and fetch is slow in log.
What is changed and how it works?
InPreapre
andHasMoreResult
in slow log too(help find question)Parse_time
andCompile_time
in slow log(it seems miss those two fields)Check List
Tests
Code changes
Side effects
Related changes
tidb-ansible
repositoryRelease note
This change is