Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, util: rename original List to ListInMemory and add a new interface List #13358

Closed
wants to merge 9 commits into from

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Nov 11, 2019

What problem does this PR solve?

Continue to change the ListInMemory.GetRow() in #13353

What is changed and how it works?

Let ListInMemory.GetRow return errors

Check List

Tests

  • No code

Code changes

  • Has exported function/method change

Side effects

  • N/A
    Related changes

  • N/A

Release note

  • N/A

@fzhedu fzhedu added the type/enhancement The issue or PR belongs to an enhancement. label Nov 11, 2019
@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #13358 into master will decrease coverage by 0.1158%.
The diff coverage is 50.4132%.

@@               Coverage Diff                @@
##             master     #13358        +/-   ##
================================================
- Coverage   80.2162%   80.1004%   -0.1159%     
================================================
  Files           469        469                
  Lines        113002     112334       -668     
================================================
- Hits          90646      89980       -666     
+ Misses        15386      15351        -35     
- Partials       6970       7003        +33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants