expression: implement vectorized evaluation for builtinNameConstJSONSig
#13384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
SunRunAway and
wshwsh12
and removed request for
a team
|
|
|
Please post the benchmark result in your PR's description~ |
Baytwt
changed the title
builtinJSONAnyValueSigbuiltinNameConstJSONSig
qw4990
added
status/LGT2
|
Your auto merge job has been accepted, waiting for 13370, 13408 |
|
/run-all-tests |
|
/run-all-tests |
|
@Baytwt merge failed. |
|
/rebuild |
qw4990
reviewed
Nov 14, 2019
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #13384 +/- ##
===========================================
Coverage ? 80.3827%
===========================================
Files ? 472
Lines ? 114843
Branches ? 0
===========================================
Hits ? 92314
Misses ? 15330
Partials ? 7199 |
qw4990
approved these changes
Nov 16, 2019
|
/build |
|
/run-unit-test |
|
@Baytwt Friendly ping, please sign the CLA license :D |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
expression: implement vectorized evaluation for
builtinNameConstJSONSigWhat is changed and how it works?
expression: implement vectorized evaluation for
builtinNameConstJSONSigCheck List
Tests