Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized evaluation for builtinNameConstJSONSig #13384

Merged
merged 13 commits into from
Nov 18, 2019
Merged

expression: implement vectorized evaluation for builtinNameConstJSONSig #13384

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e187597
Merge pull request #1 from pingcap/master
Baytwt Nov 11, 2019
effc27d
Merge pull request #2 from pingcap/master
Baytwt Nov 12, 2019
3dff672
Update builtin_miscellaneous_vec_test.go
Baytwt Nov 12, 2019
c2186f6
Update builtin_miscellaneous_vec.go
Baytwt Nov 12, 2019
01f88ed
Merge branch 'master' into master
qw4990 Nov 14, 2019
0048bdb
Merge branch 'master' into master
sre-bot Nov 14, 2019
ae947bf
Update builtin_miscellaneous_vec_test.go
Baytwt Nov 16, 2019
6034e40
Update builtin_miscellaneous_vec_test.go
Baytwt Nov 16, 2019
95bae74
Merge branch 'master' into master
qw4990 Nov 16, 2019
ed51897
Merge branch 'master' into master
qw4990 Nov 16, 2019
3a8da6b
Merge branch 'master' into master
qw4990 Nov 16, 2019
a1bac61
Merge branch 'master' into master
qw4990 Nov 18, 2019
02dc3f2
Merge branch 'master' into master
qw4990 Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions expression/builtin_miscellaneous_vec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,11 +324,11 @@ func (b *builtinNameConstDecimalSig) vecEvalDecimal(input *chunk.Chunk, result *
}

func (b *builtinNameConstJSONSig) vectorized() bool {
return false
return true
}

func (b *builtinNameConstJSONSig) vecEvalJSON(input *chunk.Chunk, result *chunk.Column) error {
return errors.Errorf("not implemented")
return b.args[1].VecEvalJSON(b.ctx, input, result)
}

func (b *builtinInet6AtonSig) vectorized() bool {
Expand Down
1 change: 1 addition & 0 deletions expression/builtin_miscellaneous_vec_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ var vecBuiltinMiscellaneousCases = map[string][]vecExprBenchCase{
{retEvalType: types.ETDecimal, childrenTypes: []types.EvalType{types.ETString, types.ETDecimal}},
{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETString, types.ETInt}},
{retEvalType: types.ETReal, childrenTypes: []types.EvalType{types.ETString, types.ETReal}},
{retEvalType: types.ETJSON, childrenTypes: []types.EvalType{types.ETString, types.ETJSON}},
qw4990 marked this conversation as resolved.
Show resolved Hide resolved
{retEvalType: types.ETTimestamp, childrenTypes: []types.EvalType{types.ETString, types.ETTimestamp}},
},
}
Expand Down