Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: improve test coverage of /debug/zip api #13486

Merged
merged 7 commits into from
Nov 22, 2019
Merged

server: improve test coverage of /debug/zip api #13486

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0f7139a
server: improve test coverage of api
Deardrops Nov 13, 2019
1c347e3
Merge branch 'master' into server-debug-zip
Deardrops Nov 21, 2019
cc6582c
Merge branch 'master' into server-debug-zip
Deardrops Nov 21, 2019
9976853
Merge branch 'master' into server-debug-zip
Deardrops Nov 21, 2019
f5cbc6a
address comment
Deardrops Nov 21, 2019
bc1fde2
Merge branch 'master' into server-debug-zip
Deardrops Nov 22, 2019
3cb0c66
Merge branch 'master' into server-debug-zip
Deardrops Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions server/http_handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,8 +879,20 @@ func (ts *HTTPHandlerTestSuite) TestHotRegionInfo(c *C) {
func (ts *HTTPHandlerTestSuite) TestDebugZip(c *C) {
ts.startServer(c)
defer ts.stopServer(c)
resp, err := http.Get("http://127.0.0.1:10090/debug/zip")
resp, err := http.Get("http://127.0.0.1:10090/debug/zip?seconds=1")
c.Assert(err, IsNil)
defer resp.Body.Close()
c.Assert(resp.StatusCode, Equals, http.StatusOK)
out, err := os.Create("/tmp/tidb_debug.zip")
c.Assert(err, IsNil)
_, err = io.Copy(out, resp.Body)
c.Assert(err, IsNil)
fileInfo, err := out.Stat()
c.Assert(err, IsNil)
c.Assert(fileInfo.Size(), Greater, int64(0))
err = out.Close()
c.Assert(err, IsNil)
err = os.Remove("/tmp/tidb_debug.zip")
c.Assert(err, IsNil)
err = resp.Body.Close()
c.Assert(err, IsNil)
}