-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: improve test coverage of /debug/zip
api
#13486
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13486 +/- ##
===========================================
Coverage 79.9716% 79.9716%
===========================================
Files 473 473
Lines 116200 116200
===========================================
Hits 92927 92927
Misses 15945 15945
Partials 7328 7328 |
/run-all-tests |
/run-all-tests |
/run-unit-test |
2 similar comments
/run-unit-test |
/run-unit-test |
/run-unit-test |
/run-unit-test |
1 similar comment
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/run-all-tests |
/run-all-tests |
/run-unit-test |
What problem does this PR solve?
Improving test coverage of
server
packageAdd test coverage for
tidb/server/http_status.go
Lines 204 to 228 in b274eb2
What is changed and how it works?
For testing
/debug/zip
api, We copy data in the http response to local temp file for ensuring data transport finished. This way also ensure all logic in/debug/zip
will executed.This PR is part of #11760
Check List
Tests