-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: refine error code for package infoschema
#13646
Conversation
/run-common-test tidb-test=pr/954 |
/run-integration-common-test tidb-test=pr/954 |
Codecov Report
@@ Coverage Diff @@
## master #13646 +/- ##
===========================================
Coverage 80.1239% 80.1239%
===========================================
Files 473 473
Lines 116512 116512
===========================================
Hits 93354 93354
Misses 15819 15819
Partials 7339 7339 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests tidb-test=pr/954 |
@bb7133, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@Deardrops merge failed. |
@Deardrops merge failed, PTAL |
/run-all-tests tidb-test=pr/954 |
/run-unit-test |
What problem does this PR solve?
Not all the errors in infoschema package have error code.
Make some errors related to
CREATE USER / ALTER USER / DROP USER
statement compatibly with MySQL 5.7, e.g.What is changed and how it works?
Add them, related PR pingcap/parser#644
Check List
Tests
Code changes
Side effects
Related changes
Release note