meta: refine error code for package meta
#13654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13654 +/- ##
===========================================
Coverage 80.0683% 80.0683%
===========================================
Files 474 474
Lines 116734 116734
===========================================
Hits 93467 93467
Misses 15882 15882
Partials 7385 7385 |
Deardrops
added
type/enhancement
|
/run-all-tests |
|
/run-all-tests |
crazycs520
reviewed
Nov 26, 2019
zimulala
reviewed
Nov 26, 2019
|
/run-unit-test |
zimulala
reviewed
Nov 26, 2019
|
/run-all-tests |
zimulala
reviewed
Nov 26, 2019
Deardrops
commented
Nov 26, 2019
| @@ -290,6 +294,7 @@ func (s *testSuite) TestSnapshot(c *C) { | |||
| c.Assert(n, Equals, int64(1)) | |||
| _, err = snapMeta.GenGlobalID() | |||
| c.Assert(err, NotNil) | |||
| c.Assert(err.Error(), Equals, "[structure:5]write on snapshot") | |||
There was a problem hiding this comment.
This is an unexported error, so we check it by compare string.
|
/run-all-tests |
|
/run-all-tests |
Deardrops
added
status/LGT2
qw4990
pushed a commit
to qw4990/tidb
that referenced
this pull request
Nov 27, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Not all the errors in meta package have error code.
What is changed and how it works?
add them.
Check List
Tests
Code changes
Side effects
Related changes
Release note