-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, executor: build ColWithCmpFuncManager.TmpConstant for indexJoin.innerWorker individually #13669
Conversation
…oin.innerWorker individually
Codecov Report
@@ Coverage Diff @@
## master #13669 +/- ##
================================================
- Coverage 80.4178% 79.9334% -0.4845%
================================================
Files 474 473 -1
Lines 119767 115909 -3858
================================================
- Hits 96314 92650 -3664
+ Misses 16048 15955 -93
+ Partials 7405 7304 -101 |
/run-all-tests |
} | ||
tk.MustExec("insert into s select a, b - 1 from t") | ||
tk.MustExec("analyze table t;") | ||
tk.MustExec("analyze table s;") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to analyze these tables since we are using hint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noe need. But it can make the test stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
…oin.innerWorker individually (pingcap#13669)
What problem does this PR solve?
Before this commit, the query result is not stable:
What is changed and how it works?
Build ColWithCmpFuncManager.TmpConstant for indexJoin.innerWorker individually.
Thus the modifications triggered by each inner worker will not affect the others.
Check List
Tests
Code changes
Side effects
N/A
Related changes
release-3.0
Release note