server: fix potential timezone related bugs caused by time.Local
#14572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz-jason
reviewed
Jan 27, 2020
zz-jason
added
component/server
needs-cherry-pick-2.1
type/bugfix
|
@sre-bot /run-all-tests |
|
/run-all-tests |
Rustin170506
force-pushed
the
rustin-patch-server-util
branch
2 times, most recently
from
f49fb14 to
c5f0c0b
Compare
server: add test case server: add more test cases server: add assert to time zone server: add assert
Rustin170506
force-pushed
the
rustin-patch-server-util
branch
2 times, most recently
from
63f6628 to
74b0382
Compare
|
Pass all tests, PTAL~ |
ngaut
added
status/can-merge
|
/run-all-tests |
|
@Rustin-Liu merge failed. |
|
@sre-bot /run-all-tests |
|
/run-all-tests |
|
@sre-bot /merge |
|
@Rustin-Liu we are working on the CI problem. |
|
lgtm |
reafans
approved these changes
Feb 14, 2020
reafans
added
status/LGT1
|
cherry pick to release-3.0 failed |
|
cherry pick to release-2.1 failed |
|
@bb7133 cherry-pick failed. |
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1 release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @zz-jason PTAL. |
zz-jason
added
needs-cherry-pick-2.1
status/LGT2
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-2.1 in PR #16185 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #16186 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #16187 |
sre-bot
added a commit
that referenced
this pull request
Apr 15, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#13626
What is changed and how it works?
Check List
Tests
None
Code changes
None
Side effects
None
Related changes
None
Release note
None