Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: fix potential timezone related bugs caused by time.Local (#14572) #16185

Merged
merged 5 commits into from
Apr 15, 2020
Merged

server: fix potential timezone related bugs caused by time.Local (#14572) #16185

merged 5 commits into from
Apr 15, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 8, 2020

cherry-pick #14572 to release-2.1

What problem does this PR solve?

#13626

What is changed and how it works?

Check List

Tests

None

Code changes

None

Side effects

None

Related changes

None

Release note

None

@Rustin170506 @sre-bot
cherry pick pingcap#14572 to release-2.1
0a4bf06 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 8, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 8, 2020
Merged
@sre-bot sre-bot added component/server contribution This PR is from a community contributor. type/2.1-cherry-pick type/bugfix This PR fixes a bug. labels Apr 8, 2020
@sre-bot sre-bot requested review from bb7133, ngaut, reafans and zz-jason April 8, 2020 06:40
zz-jason
zz-jason reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reafans Please help to resolve the conflict.

@zz-jason zz-jason removed request for ngaut, bb7133 and reafans April 13, 2020 07:43
@reafans
Copy link
Contributor

reafans commented Apr 15, 2020

/run-unit-test

@XuHuaiyu XuHuaiyu requested a review from zz-jason April 15, 2020 11:48
zz-jason
zz-jason reviewed Apr 15, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested a review from SunRunAway April 15, 2020 13:03
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2020
SunRunAway
SunRunAway approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

Your auto merge job has been accepted, waiting for 16405

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot sre-bot merged commit 8f2afff into pingcap:release-2.1 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

Assignees

@reafans reafans

Labels
component/server contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/2.1-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @reafans @SunRunAway @zz-jason @Rustin170506