Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: avoid check schema changed when change is tiflash replica replica status (#13034) #14884

Merged
merged 2 commits into from
Feb 21, 2020
Merged

domain: avoid check schema changed when change is tiflash replica replica status (#13034) #14884

merged 2 commits into from
Feb 21, 2020

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry-pick #10343

@crazycs520
domain: avoid check schema changed when change is tiflash replica sta…
ce947e2 
…tus (pingcap#13034)

Signed-off-by: crazycs <crazycs520@gmail.com>
@crazycs520 crazycs520 changed the title domain: avoid check schema changed when change is tiflash replica sta… domain: avoid check schema changed when change is tiflash replica replica status (#13034) Feb 21, 2020
@crazycs520
Copy link
Contributor Author

/run-all-tests

Deardrops
Deardrops reviewed Feb 21, 2020
View reviewed changes
Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

djshow832
djshow832 previously approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deardrops Deardrops added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 21, 2020
@crazycs520
Copy link
Contributor Author

/rebuild

2 similar comments
@crazycs520
Copy link
Contributor Author

/rebuild

@crazycs520
Copy link
Contributor Author

/rebuild

@crazycs520
Copy link
Contributor Author

/run-unit-test

@crazycs520
Copy link
Contributor Author

/run-all-tests

@bb7133 bb7133 merged commit f90a789 into pingcap:release-3.1 Feb 21, 2020
@bb7133 bb7133 added this to the v3.1.0-rc milestone Feb 21, 2020
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deardrops Deardrops Deardrops left review comments

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v3.1.0-rc
Development

Successfully merging this pull request may close these issues.
6 participants
@crazycs520 @Deardrops @djshow832 @bb7133 @you06 @lysu