Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pd-client to support pd client tls reload #15071

Merged
merged 2 commits into from
Mar 9, 2020
Merged

upgrade pd-client to support pd client tls reload #15071

merged 2 commits into from
Mar 9, 2020

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Mar 2, 2020

What problem does this PR solve?

upgrade pd-client to newest version to support reload cluster-tls

also upgrade tidb-tools which use pd-client too(pingcap/tidb-tools#320 but it meets some CI problem due to pd's new go mod version)

What is changed and how it works?

upgrade dep

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • go.mod and import

Side effects

  • n/a

Related changes

  • n/a

Release note

  • Write release note for bug-fix or new feature.

This change is Reviewable

@lysu lysu added CHANGELOG component/build security Everything related with security and removed CHANGELOG labels Mar 2, 2020
@lysu
Copy link
Contributor Author

lysu commented Mar 2, 2020

need wait pingcap/tidb-tools#320 merge

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #15071 into master will decrease coverage by 0.1295%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #15071        +/-   ##
================================================
- Coverage   80.4574%   80.3279%   -0.1296%     
================================================
  Files           503        503                
  Lines        133693     132777       -916     
================================================
- Hits         107566     106657       -909     
+ Misses        17752      17723        -29     
- Partials       8375       8397        +22

@lysu
Copy link
Contributor Author

lysu commented Mar 9, 2020

@lysu
Copy link
Contributor Author

lysu commented Mar 9, 2020

/run-all-tests

@lysu
Copy link
Contributor Author

lysu commented Mar 9, 2020

/run-unit-test

@lysu lysu requested review from imtbkcat, jackysp and tiancaiamao March 9, 2020 08:43
@imtbkcat imtbkcat added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2020
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Mar 9, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 9, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 9, 2020

cherry pick to release-3.0 in PR #15243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build security Everything related with security status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants