Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update the recent improvements about tls/security #2417

Merged
merged 20 commits into from
Apr 15, 2020
Merged

*: update the recent improvements about tls/security #2417

merged 20 commits into from
Apr 15, 2020

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Mar 9, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version, including v4.0 changes for now)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

This change is Reviewable

@lysu lysu added status/DNM status/WIP This PR is still working in progress. labels Mar 9, 2020
@TomShawn TomShawn self-assigned this Mar 11, 2020
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. v4.0 This PR/issue applies to TiDB v4.0. labels Mar 11, 2020
@lysu lysu mentioned this pull request Mar 11, 2020
Closed
@TomShawn TomShawn changed the title update the recent improvements about tls/security *: update the recent improvements about tls/security Mar 13, 2020
@TomShawn TomShawn assigned toutdesuite and unassigned TomShawn Mar 25, 2020
@yikeke yikeke added the status/require-change Needs the author to address comments. label Apr 14, 2020
lysu
lysu commented Apr 14, 2020
View reviewed changes
how-to/secure/enable-tls-clients.md Outdated Show resolved Hide resolved
how-to/secure/enable-tls-clients.md Outdated Show resolved Hide resolved
how-to/secure/enable-tls-clients.md Outdated Show resolved Hide resolved
how-to/secure/enable-tls-clients.md Outdated Show resolved Hide resolved
reference/sql/statements/alter-instance.md Outdated Show resolved Hide resolved
@lysu lysu requested review from TomShawn and jackysp April 14, 2020 09:11
@lysu lysu removed status/DNM status/require-change Needs the author to address comments. labels Apr 14, 2020
TomShawn
TomShawn approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot sre-bot merged commit cb68a5f into pingcap:master Apr 15, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 15, 2020
@lysu @sre-bot
*: update the recent improvements about tls/security (pingcap#2417)
3e4e447
@sre-bot sre-bot mentioned this pull request Apr 15, 2020
Merged
4 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

cherry pick to release-4.0 in PR #2761

TomShawn pushed a commit that referenced this pull request Apr 15, 2020
@sre-bot @lysu
*: update the recent improvements about tls/security (#2417) (#2761)
e2270be 
Co-authored-by: lysu <sulifx@gmail.com>
@toutdesuite toutdesuite added the requires-followup This PR requires a follow-up task after being merged. label May 8, 2020
@toutdesuite toutdesuite mentioned this pull request May 8, 2020
Merged
5 tasks
@TomShawn
Copy link
Contributor

TomShawn commented May 8, 2020

/run-cherry-picker

@toutdesuite toutdesuite added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed requires-followup This PR requires a follow-up task after being merged. translation/doing This PR’s assignee is translating this PR. labels May 8, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 8, 2020
@lysu @sre-bot
*: update the recent improvements about tls/security (pingcap#2417)
600fa71
@sre-bot sre-bot mentioned this pull request May 8, 2020
Merged
4 tasks
@sre-bot
Copy link
Contributor

sre-bot commented May 8, 2020

cherry pick to release-3.1 in PR #2999

TomShawn pushed a commit that referenced this pull request May 8, 2020
@sre-bot @lysu
*: update the recent improvements about tls/security (#2417) (#2999)
ce6ea34 
Co-authored-by: lysu <sulifx@gmail.com>
@lysu lysu mentioned this pull request May 8, 2020
Merged
5 tasks
This was referenced May 8, 2020
Merged
Merged
Merged
Merged
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
@lysu @rleungx
*: update the recent improvements about tls/security (pingcap#2417)
eaf6cce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@toutdesuite toutdesuite

Labels
status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v4.0 This PR/issue applies to TiDB v4.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lysu @sre-bot @TomShawn @jackysp @toutdesuite @yikeke