-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support reload tls used by mysql protocol in place #14749
Conversation
|
I'd like to see this backported to 3.1 and maybe 3.0. |
/rebuild |
1 similar comment
/rebuild |
Codecov Report
@@ Coverage Diff @@
## master #14749 +/- ##
===========================================
Coverage 80.6497% 80.6497%
===========================================
Files 502 502
Lines 133409 133409
===========================================
Hits 107594 107594
Misses 17426 17426
Partials 8389 8389 |
/rebuild |
@jackysp @tiancaiamao finally it passes all test, PTAL tks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
/merge |
/run-all-tests |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-3.0 in PR #15080 |
cherry pick to release-4.0 in PR #15081 |
It seems that, not for sure, we failed to cherry-pick this commit to release-3.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @lysu PTAL. |
What problem does this PR solve?
ref #14666
preliminary support reload tls used by mysql protocol
this PR doesn't try to full support mysql's dynamic modify "ssl_ca/ssl_key/ssl_cert" value, but can reload tls used old file path specified by old "ssl_ca/ssl_key/ssl_cert" value(so ssl_cert/ssl_ca/ssl_key keep read-only after this PR).
so user can:
alter instance reload tls
then all new db connection will use new cert file, old connection will keep work just like mysql does
What is changed and how it works?
LoadTLSCertificates
server.tlsConfig
can be atomic swapCheck List
Tests
Code changes
Side effects
Related changes
Release note
This change is