-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chunk: make mysql.TypeNull
be judged as fixedLen
#15512
Conversation
bug caused by Line 713 in c1114b9
source chunk |
mysql.TypeNull
be judged as fixedLen
Codecov Report
@@ Coverage Diff @@
## master #15512 +/- ##
================================================
- Coverage 80.5692% 80.5006% -0.0686%
================================================
Files 504 502 -2
Lines 135203 134348 -855
================================================
- Hits 108932 108151 -781
+ Misses 17774 17741 -33
+ Partials 8497 8456 -41 |
/run-all-tests |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your auto merge job has been accepted, waiting for 15628, 15635, 15711 |
/run-all-tests |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-3.0 in PR #15738 |
cherry pick to release-3.1 in PR #15739 |
cherry pick to release-4.0 in PR #15740 |
/run-cherry-picker |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-2.1 in PR #15930 |
What problem does this PR solve?
Issue Number: close #6252
Problem Summary:
What is changed and how it works?
fix:
What's Changed:
try let TypeNull as fixedLen column in the chunk
How it Works:
try let TypeNull as fixedLen column in the chunk
Related changes
Check List
Tests
WIP
Side effects
Release note
fix panic when sort/topn above left join with null column in right child
This change is