Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, util: new unfixed mutrow for TypeNull #17893

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Jun 10, 2020

What problem does this PR solve?

Issue Number: close #16027 #6252

Problem Summary:
TypeNull should be handled as unfixedLen field type. refer MySQL: https://github.com/mysql/mysql-server/blob/8.0/sql/field.h#L151

What is changed and how it works?

What's Changed:
makeMutRowBytesColumn for nil

How it Works:
The reason is mentioned in #15512 (comment).

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

N/A

Release note

  • Fix panic when the child of HashJoin returns TypeNull column.

@XuHuaiyu
Copy link
Contributor Author

/rebuild

@zyxbest
Copy link
Contributor

zyxbest commented Jun 10, 2020

/rebuild

@XuHuaiyu XuHuaiyu changed the title planner: update go.mod to make TypeNull as EvalInt planner, util: new unfixed mutrow for TypeNull Jun 10, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Jun 10, 2020
@XuHuaiyu
Copy link
Contributor Author

related PR: #15512

@XuHuaiyu XuHuaiyu requested review from lysu and qw4990 June 10, 2020 11:14
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 11, 2020
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

/run-all-tests

@sre-bot sre-bot merged commit a689df0 into pingcap:master Jun 11, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Jun 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

cherry pick to release-2.1 in PR #17934

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Jun 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

cherry pick to release-3.0 in PR #17935

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Jun 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

cherry pick to release-3.1 in PR #17936

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Jun 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

cherry pick to release-4.0 in PR #17937

ti-srebot pushed a commit that referenced this pull request Jun 17, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: HuaiyuXu <391585975@qq.com>
Co-authored-by: goroutine <ngaut@users.noreply.github.com>
Co-authored-by: Lynn <zimu_xia@126.com>
Co-authored-by: Zhang Jian <zjsariel@gmail.com>
ti-srebot added a commit that referenced this pull request Jun 28, 2020
* cherry pick #17893 to release-3.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* resolve conflicts

Co-authored-by: HuaiyuXu <391585975@qq.com>
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Co-authored-by: Yuanjia Zhang <zhangyuanjia@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LEFT JOIN on a view results in "runtime error: slice bounds out of range [:264] with capacity 256"
5 participants