-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, util: new unfixed mutrow for TypeNull #17893
Conversation
/rebuild |
/rebuild |
related PR: #15512 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-2.1 in PR #17934 |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-3.0 in PR #17935 |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-3.1 in PR #17936 |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-4.0 in PR #17937 |
Signed-off-by: sre-bot <sre-bot@pingcap.com> Co-authored-by: HuaiyuXu <391585975@qq.com> Co-authored-by: goroutine <ngaut@users.noreply.github.com> Co-authored-by: Lynn <zimu_xia@126.com> Co-authored-by: Zhang Jian <zjsariel@gmail.com>
* cherry pick #17893 to release-3.0 Signed-off-by: sre-bot <sre-bot@pingcap.com> * resolve conflicts Co-authored-by: HuaiyuXu <391585975@qq.com> Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com> Co-authored-by: Yuanjia Zhang <zhangyuanjia@pingcap.com>
What problem does this PR solve?
Issue Number: close #16027 #6252
Problem Summary:
TypeNull should be handled as unfixedLen field type. refer MySQL: https://github.com/mysql/mysql-server/blob/8.0/sql/field.h#L151
What is changed and how it works?
What's Changed:
makeMutRowBytesColumn
fornil
How it Works:
The reason is mentioned in #15512 (comment).
Related changes
Check List
Tests
Side effects
N/A
Release note