Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: create partition table fail with strconv.ParseInt invalid syntax (#16436) #16498

Merged
merged 3 commits into from
Apr 17, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 16, 2020

cherry-pick #16436 to release-3.0


What problem does this PR solve?

Issue Number: close #16333

Problem Summary:

mysql> create table t (dt timestamp) partition by range (unix_timestamp(dt)) (partition p0 values less than (unix_timestamp('2020-04-15 00:00:00')));
ERROR 1105 (HY000): strconv.ParseInt: parsing "unix_timestamp(\"2020-04-15 00:00:00\")": invalid syntax

What is changed and how it works?

Proposal: xxx

What's Changed:

Fix bug

How it Works:

During the create of the table, the partition information should be convert to integer.
The 'less than xxx' part of a partition in the model should be integers.

I don't know why it's broken and which PR cause this.
4.0 is fine.

Tests

  • Unit test

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 16, 2020

/run-all-tests

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

/run-all-tests
PTAL @jackysp @zimulala

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Apr 17, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

/run-all-tests

@sre-bot sre-bot merged commit 0c67b23 into pingcap:release-3.0 Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants