-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: create partition table fail with strconv.ParseInt invalid syntax #16436
Conversation
PTAL @imtbkcat @crazycs520 @jackysp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to cherry-pick to v4.0?
I don't know why but this test case success in 4.0 |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #16436 +/- ##
===========================================
Coverage 80.5322% 80.5322%
===========================================
Files 506 506
Lines 136939 136939
===========================================
Hits 110280 110280
Misses 18104 18104
Partials 8555 8555 |
/run-sqllogic-test-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-3.0 in PR #16498 |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-3.1 in PR #16499 |
cherry pick to release-4.0 in PR #16500 |
What problem does this PR solve?
Issue Number: close #16333
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Fix bug
How it Works:
During the create of the table, the partition information should be convert to integer.
The 'less than xxx' part of a partition in the model should be integers.
I don't know why it's broken and which PR cause this.
4.0 is fine.
Tests