ddl: create partition table fail with strconv.ParseInt invalid syntax (#16436) #16499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
sig/sql-infra
zimulala
reviewed
Apr 17, 2020
ddl/db_partition_test.go
Outdated
| @@ -261,6 +261,26 @@ func (s *testIntegrationSuite9) TestCreateTableWithPartition(c *C) { | |||
| PARTITION p2 VALUES LESS THAN (2000), | |||
| PARTITION p3 VALUES LESS THAN (2005) | |||
| );`, tmysql.ErrBadField) | |||
| <<<<<<< HEAD | |||
| ======= | |||
There was a problem hiding this comment.
@tiancaiamao Please fix conflicts.
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16436 to release-3.1
What problem does this PR solve?
Issue Number: close #16333
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Fix bug
How it Works:
During the create of the table, the partition information should be convert to integer.
The 'less than xxx' part of a partition in the model should be integers.
I don't know why it's broken and which PR cause this.
4.0 is fine.
Tests