plan: make query on partition table not cacheable (#16375) #16723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
sig/execution
ghost
requested review from
zz-jason
reviewed
Apr 22, 2020
There was a problem hiding this comment.
@imtbkcat build failed, PTAL
[2020-04-22T14:00:09.440Z] # github.com/pingcap/tidb/planner/core
[2020-04-22T14:00:09.440Z] planner/core/common_plans.go:338:10: e.setFoundInPlanCache undefined (type *Execute has no field or method setFoundInPlanCache)
[2020-04-22T14:00:09.440Z] make: *** [importer] Error 2
[2020-04-22T14:00:09.696Z] # github.com/pingcap/tidb/planner/core
[2020-04-22T14:00:09.696Z] planner/core/common_plans.go:338:10: e.setFoundInPlanCache undefined (type *Execute has no field or method setFoundInPlanCache)
[2020-04-22T14:00:09.696Z] # github.com/pingcap/tidb/planner/core
[2020-04-22T14:00:09.696Z] planner/core/common_plans.go:338:10: e.setFoundInPlanCache undefined (type *Execute has no field or method setFoundInPlanCache)
|
PTAL @zz-jason |
imtbkcat
added
the
priority/release-blocker
zz-jason
approved these changes
Apr 23, 2020
zz-jason
added
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16375 to release-4.0
What problem does this PR solve?
Issue Number: close #16364
Problem Summary:
#15697 will check whether plan is a query on partition table and will pass by if is true. But there is still some problems bring by
stmtCtx.UseCache. If a plan isCacheable,stmtCtx.UseCacheis set totrue. So thesimpleRewriterhas different output compare with not cached plan.For example, in #16364. If prepare-plan-cache is on, although query on partition table is not cached, it has different plan.
not use cache:
lt(test.employees.id, 3)use cache:
lt(cast(test.employees.id), 3)this small change in
rewritercause partition pruning fail.What is changed and how it works?
Proposal: xxx
What's Changed:
add partition check in
Cacheablefunction rather thangetPhysicalPlanRelated changes
Check List
Tests
Side effects
Release note