plan: do not cache plan for query on range partition table #15697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
removed their request for review
Codecov Report
@@ Coverage Diff @@
## master #15697 +/- ##
===========================================
Coverage ? 80.7021%
===========================================
Files ? 504
Lines ? 135746
Branches ? 0
===========================================
Hits ? 109550
Misses ? 17703
Partials ? 8493 |
|
can we block all query on partition table to be filled into plan cache? |
|
@zz-jason for hash partition, plan cache is supported. |
zz-jason
added
status/can-merge
|
/run-all-tests |
|
@imtbkcat merge failed. |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 26, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #15748 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 26, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #15749 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 26, 2020
|
cherry pick to release-4.0 in PR #15750 |
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Mar 30, 2020
sre-bot
added a commit
that referenced
this pull request
Mar 30, 2020
sre-bot
pushed a commit
that referenced
this pull request
Apr 7, 2020
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15720
Problem Summary:
Query on range partition may return error when using prepared plan cache, because table id is written in physical plan. Some user may use partition + plan cache when TiDB 4.0-rc released. So currently let plan-cache do not cache query on range partition table.
What is changed and how it works?
Proposal: xxx
What's Changed:
Add
isRangePartitionto check whether a plan is on range partition table.How it Works:
If a plan is on range partition table, plan cache will not cache it.
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tidb-ansible:Check List
Tests
Side effects
Release note