-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plan: make query on partition table not cacheable (#16375) #16759
Merged
zz-jason
merged 3 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-79211fe63d22
Apr 29, 2020
Merged
plan: make query on partition table not cacheable (#16375) #16759
zz-jason
merged 3 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-79211fe63d22
Apr 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
sre-bot
added
sig/execution
SIG execution
component/expression
sig/planner
SIG: Planner
type/3.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
Apr 23, 2020
LGTM |
jackysp
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Apr 29, 2020
/run-all-tests |
@sre-bot merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/expression
sig/execution
SIG execution
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT1
Indicates that a PR has LGTM 1.
type/bugfix
This PR fixes a bug.
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16375 to release-3.0
What problem does this PR solve?
Issue Number: close #16364
Problem Summary:
#15697 will check whether plan is a query on partition table and will pass by if is true. But there is still some problems bring by
stmtCtx.UseCache
. If a plan isCacheable
,stmtCtx.UseCache
is set totrue
. So thesimpleRewriter
has different output compare with not cached plan.For example, in #16364. If prepare-plan-cache is on, although query on partition table is not cached, it has different plan.
not use cache:
lt(test.employees.id, 3)
use cache:
lt(cast(test.employees.id), 3)
this small change in
rewriter
cause partition pruning fail.What is changed and how it works?
Proposal: xxx
What's Changed:
add partition check in
Cacheable
function rather thangetPhysicalPlan
Related changes
Check List
Tests
Side effects
Release note