tikv: fix "Got too many pings" GRPC error in PD-server follower #17885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysu
changed the title
Codecov Report
@@ Coverage Diff @@
## master #17885 +/- ##
================================================
- Coverage 79.5047% 79.4261% -0.0787%
================================================
Files 524 524
Lines 142160 141923 -237
================================================
- Hits 113024 112724 -300
- Misses 20006 20064 +58
- Partials 9130 9135 +5 |
|
LGTM |
jackysp
previously approved these changes
Jun 10, 2020
|
There are multiple |
|
And in TiKV server-side, |
|
@HunDunDM updated = = |
hicqu
previously approved these changes
Jun 11, 2020
jackysp
previously approved these changes
Jun 11, 2020
|
/merge |
|
Sorry @jackysp, you don't have permission to trigger auto merge event on this branch. You are not a committer for this part |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@lysu merge failed. |
|
Maybe we can enable |
|
/merge |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #17944 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #17946 |
HunDunDM
reviewed
Jun 11, 2020
| @@ -674,9 +674,8 @@ func (do *Domain) Init(ddlLease time.Duration, sysFactory func(*Domain) (pools.R | |||
| DialOptions: []grpc.DialOption{ | |||
| grpc.WithBackoffMaxDelay(time.Second * 3), | |||
| grpc.WithKeepaliveParams(keepalive.ClientParameters{ | |||
There was a problem hiding this comment.
It is better to use DialKeepAliveTime and DialKeepAliveTimeout directly in clientv3.Config instead of grpc.WithKeepaliveParams. Just like kv.go.
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #17947 |
sre-bot
added a commit
that referenced
this pull request
Jun 11, 2020
…) (#17947) Signed-off-by: sre-bot <sre-bot@pingcap.com> Co-authored-by: lysu <sulifx@gmail.com>
cannium
added a commit
to cannium/br
that referenced
this pull request
Jun 18, 2020
By setting "PermitWithoutStream" to false, configurations are consistent between server(pd) and client(br) side. Already fixed in tidb: pingcap/tidb#17885
overvenus
pushed a commit
to pingcap/br
that referenced
this pull request
Jun 23, 2020
By setting "PermitWithoutStream" to false, configurations are consistent between server(pd) and client(br) side. Already fixed in tidb: pingcap/tidb#17885
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Jun 23, 2020
By setting "PermitWithoutStream" to false, configurations are consistent between server(pd) and client(br) side. Already fixed in tidb: pingcap/tidb#17885
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Jun 23, 2020
By setting "PermitWithoutStream" to false, configurations are consistent between server(pd) and client(br) side. Already fixed in tidb: pingcap/tidb#17885
overvenus
pushed a commit
to pingcap/br
that referenced
this pull request
Jun 28, 2020
By setting "PermitWithoutStream" to false, configurations are consistent between server(pd) and client(br) side. Already fixed in tidb: pingcap/tidb#17885 Co-authored-by: can <can@canx.me>
overvenus
pushed a commit
to pingcap/br
that referenced
this pull request
Jun 28, 2020
By setting "PermitWithoutStream" to false, configurations are consistent between server(pd) and client(br) side. Already fixed in tidb: pingcap/tidb#17885 Co-authored-by: can <can@canx.me>
zz-jason
pushed a commit
that referenced
this pull request
Jun 28, 2020
ti-srebot
pushed a commit
that referenced
this pull request
Jul 21, 2020
…) (#17946) Signed-off-by: sre-bot <sre-bot@pingcap.com>
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17870
Problem Summary:
In PD(etcd) server side,
PermitWithoutStreamvalues isfalsehttps://github.com/etcd-io/etcd/blob/master/embed/etcd.go#L641, meansbut in TiDB client side,
PermitWithoutStreamvalues istruemeansso, with those conflict configuration, grpc server side will count pingStrike with wrong value.
https://github.com/grpc/grpc-go/blob/master/internal/transport/http2_server.go#L711
and report "transport: Got too many pings from the client, closing the connection." error.
What is changed and how it works?
What's Changed, How it Works:
we need keep them both as true or false, but etcd write it with magic value(false)
so we only can change tidb-side to false
Related changes
Check List
Tests
Side effects
Release note
This change is