-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv: fix "Got too many pings" GRPC error in PD-server follower (#17885) #17946
tikv: fix "Got too many pings" GRPC error in PD-server follower (#17885) #17946
Conversation
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@sre-bot merge failed. |
/merge |
/run-all-tests |
@sre-bot merge failed. |
/merge |
/run-all-tests |
@sre-bot merge failed. |
/rebuild |
/run-unit-test |
/merge |
/run-all-tests |
cherry-pick #17885 to release-3.1
What problem does this PR solve?
Issue Number: close #17870
Problem Summary:
In PD(etcd) server side,
PermitWithoutStream
values isfalse
https://github.com/etcd-io/etcd/blob/master/embed/etcd.go#L641, meansbut in TiDB client side,
PermitWithoutStream
values istrue
meansso, with those conflict configuration, grpc server side will count pingStrike with wrong value.
https://github.com/grpc/grpc-go/blob/master/internal/transport/http2_server.go#L711
and report "transport: Got too many pings from the client, closing the connection." error.
What is changed and how it works?
What's Changed, How it Works:
we need keep them both as true or false, but etcd write it with magic value(false)
so we only can change tidb-side to false
Related changes
Check List
Tests
Side effects
Release note
This change is